Repository navigation
Conversation
A go-makefile-maker run dropped the quoting around the release-scoped ClusterRole name, breaking make generate and the pre-commit make check hook. The quoting now lives in the configured value itself, so future regenerations keep a working Makefile. Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
fwiesel
force-pushed
the
run-go-makefile-maker
branch
from
November 9, 2026 14:26
5c1ef62 to
c859229
Compare
Contributor
Author
|
Folding this into the make generate fix PR as a second commit — one PR, both changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Run go-makefile-makercheck (which runs the maker at@latest) reports generated-file drift: the pinned action versions in the autogenerated workflows are behind the current maker release.This commit runs the maker locally and commits the result — action-pin bumps in four workflow files, no functional changes.